On 3/29/07, Maximilian Albert <Anhalter42@...173...> wrote:
Hi all,
I am currently playing around with the code to get familiar with it and find out how things work. Sometimes I stumble across a piece of functionality that is apparently missing (or I am not able to find it). The most recent example is that I wanted to flip an entire path horizontally about one of its selected nodes - AFAICT from the code, flipping is only supported about the center of a selection. So I went ahead and tried to implement that, which worked surprisingly well.
Not really surprisingly, implementing simple things in Inkscape is usually easy :)
I don't remember anyone requesting this particular feature, but it makes perfect sense. What about the UI, though? (I cannot try your patch right now, as I'm in the middle of an upgrade and cannot yet compile.) I propose the following: pressing H and V in the Node tool already flips the selected nodes; all you need to do is to check if any of the selected nodes is mouseovered and if so, use it as the center. This way you can flip only the selected nodes or the entire path if you select all nodes. It does not require any new menu commands and is very easy to do; also it will be consistent with other similar actions - for example, when you join two nodes, usually both go half-way to join, but if you mouseover one of the nodes, it stays put and the other one jumps up to it.
Also in Selector, there's such thing as the rotation axis that can be freely dragged in rotate mode (and it's remembered and saved for each object). The selector's flip functions (also called by H and V) do not use it at the moment for flipping, but I think they should.
Anyway, I still reckon it's better to come up with a patch first and ask for feedback afterwards, right? In this case I'd just arrange things so that they seem convenient to me. Would I send this kind of patch to this mailing list or should I already submit it to the patch tracker?
Usually, use the patch tracker and mailing list for those changes that you are not sure are desirable and/or safe. For something simple and obvious, you can just commit your changes directly as soon as you get svn write access (I will give it to you after I review and commit your second patch - our policy is write access after two successful patches).
Thanks!