Is this two comments, or just one?
I am actually just starting work on this, so if you have patches, then you are a bit ahead of me.
On 06/05/06, Brian <diskofish@...127...> wrote:
#if defined(__isnan) # define isNaN(_a) (__isnan(_a)) /* MacOSX/Darwin definition < 10.4 */
This never gets executed by the preprocessor. Was the intent to look for something that was defined in one of the OS X libraries or that someone manually would #define __isnan?
Yes. __isnan should be defined in all versions of Darwin (well, at least since Mac OS X 10.2). Look in /usr//include/architecture/ppc/math.h (or the header for your architecture).
Also, there were a few more areas where I simply included missing header files. Is this something I should submit a patch for?
Yes. I have been wary of making patches affecting headers so as not to undo Ralf's good work, and a more important point is that not all platforms need quite the same includes. I suspect that you needed to include <libintl.h> in a few places.
If somebody else sees your work and can verify that it doesn't cause problems on other platforms, then it can perhaps go straight in.
Ben
Bob Jamison wrote:
If you look in src/isnan.h, you can see how we have looked at this in the past, and have tried to supply definitions for various architectures. If you can find a better definition for isFinite() for osx, that would be great.