Hi there,
jiho, the patch seems to be strictly cosmetic, and doesn't look like it'd be required for the OSX port. I'd say exclude it until after the release.
I tested this part of the patch and I like the result. It was so long ago that these spacers were added for some now-forgotten reason, and now it really looks better without them, or at least not worse. It also saves about 10 pixels of vertical space which is worthy these days. So I committed this part of the patch as well.
Wow that's pretty amazing how fast you deal with Inkscape code changes and improvements propositions. All I can say is thanks!
This patch wont't change anything for everybody who's using GTK themes with flat (border-less) toolbars (except gaining those 10 pixels ;P), however if you use the theme like: http://www.inkscape.org/screenshots/gallery/inkscape-0.46-01-angled_guidelin... you can see the toolbar gets outset twice, which looks basically very nasty also with OSX theme (Leopardish) I used. So the whole concept of making OSX port IMHO is too provide native OSX Quartz GTK application that will preserve as much as possible of OSX look & feel using GTK library -> which implies some cosmetic changes, just to make any Mac user to not feel the difference when using Inkscape.
Cheers!,