On Sun, Oct 09, 2016 at 07:29:08AM +0200, Christoffer Holmstedt wrote:
2016-10-08 3:02 GMT+02:00 Martin Owens <doctormo@...400...>:
On Fri, 2016-10-07 at 22:26 +0200, Christoffer Holmstedt wrote:
Hi I noticed last week that issues on github were disabled. There are now 2 complaints in a pull request concerning this.
https://github.com/inkscape/inkscape/pull/20#issuecomment-251752290
Anyone able to answer them with some explanation? I assume code will eventually move to git/github/gitlab but we are not there yet...but I'm not sure what to answer "waldyrious" and "shakaran" on Github at the moment.
I emailed both people privately explaining why the issues tracker was closed. Although it was closed for a while before, I re-opened it to close all the issues and point people to the real tracker then closed it again.
One of the two has responded by email and understands.
The main reason seems to be that the user was unwilling to join the mailing list and wanted emails from github. I'm going to note that for future because we shouldn't really divide up our community into different platform communication if possible.
Any way you can close the pull requests?
Best Regards, Martin Owens
Actually, I'm not sure if we should close the pull requests at all because it is not possible to disable pull requests on github. With Bryce's reply to the pull request it might be easier for the future to keep it open and just link to that reply in future pull requests. More pull request will eventually come that way no matter if we close or leave it open, but it will be more visible if we leave it open.
Yes, those are some good points. You're right, we do plan to move off of Launchpad at some point, at least for code hosting and reviews. The main hitch presently (apart from needing to focus on the release in the near term) is reaching a consensus on a decision between gitlab and github.
Meanwhile, I don't see too much problem to experimenting with allowing pull requests off-Launchpad, if there are volunteers such as yourself to keep an eye on things (and review/forward/land salient bits). However, I think it would save us some trouble down the road if we could finalize our decision on gitlab vs. github, so we have a clear direction forward, even if the official transition is going to wait for a while.
Bryce