On Tue, 9 Dec 2003, MenTaLguY wrote:
On Tue, 2003-12-09 at 02:32, Mael wrote:
Hello,
[ 841633 ] Icons problem for win32
I'd like to get confirmation that this still occurs, as I suspect the GtkButton rework may have resolved it. It doesn't cause a crash and sounds like its platform dependent, though. If the problem still exists, then it should be made high priority for the nextrelease.
It still exists for some icons (ex. for join/cap, and tab icon for fill,stroke,..). As a quick fix for my own build I've added code to save and restore current dir before and after an open or save file.
I think the best fix is probably to move the logic into SPIcon rather than having the path explicitly specified everywhere at all. That will touch a lot of code in the process.
Okay then let's make it high priority for 0.37 but leave it as is for this coming release.
But there are two more annoying and *very visible* bugs with win32 , at least for non english users with a comma as decimal separator (too bad I'm in this category :)
1- When the regional setting uses comma instead of dot for decimal separator (ie numbers are 234,23 instead of 234.23) inkscape appears totally broken (random lines when drawing, gradient fill not functionning..). There is a " setlocale (LC_NUMERIC, "C"); " that is supposed to fix this but somewhere later the program switch back to the locale setting ..(I can see it still uses comma in the console output)
It looks to me like the printf() family on Win32 doesn't respect Unix-style locale environment variables. The only fix is to replace them with our own non-locale-dependent code.
I have some code that we may want to consider using, that would also help us with better rounding capabilities and such. I'd be happy to dig it out and add it to the codebase for the next release, although I'd appreciate it if someone could code-review it.
2- Font problem. See previous posts about this one and the possible cause
The font problem is likely the result of the strings "italic" etc. being improperly localized, so they don't match the "style" font property as returned by nr_typeface_w32_attribute_get.
Alternately, if we ditch Sodipodi's libnrtype in favor of Pango, we can at least be assured that Pango gets it correct in the first place.
Hmm, fixing the localization should not be too difficult, should it? It sounds like that might be a better solution than moving up the change over to Pango; I'm sure that'll open a variety of other issues for us. ;-)
This is a difficult situation. I've filed high-priority bugs on these, but it looks like the fixes for them are fairly invasive and we're getting overdue for another release.
How do you all feel about this? Should we:
Delay the release until these are fixed
Release anyway, but don't do a win32 release build for this version
Go ahead and release builds for all platforms
In any case, if we don't fix these bugs for this release, they should be mandatory fixes for 0.37, which is designated for bugfixing and code cleanup.
Actually 0.37 is just code cleanup and C++-ification; 0.38 will be the big Bug Hunt release. But I agree these should be high priority for 0.37.
I don't think we should hold up 0.36; our goal was to introduce a lot of change, which we've done, not to be perfect. We'll make a line in the sand here, and over the next few releases work at ratcheting up quality notch by notch. With the bug management work done for this release we have a handle on what needs to be done. It might take several releases but I'm confident that Inkscape is going to become extremely robust.
Bryce