No I didn't. For any 2geom patch, I much rather have the original author(s) take care of it.
-----Original Message----- From: Joshua A. Andler [mailto:scislac@...400...] Sent: Monday, September 28, 2009 02:24 To: Engelen, J.B.C. (Johan) Cc: tavmjong@...8...; theadib@...1439...; inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] Call for Pre3
Johan,
Did you commit this on the 2geom end or submit it for review?
Cheers, Josh
On Mon, 2009-09-28 at 02:08 +0200, J.B.C.Engelen@...1578... wrote:
Hi guys,
Be sure to forward any changes to our copy of 2geom to
lib2geom itself!
After 0.47 release, we'll probably update our copy with the latest 2geom and your changes will be lost. (see the readme file in the 2geom dir)
Ciao, Johan
-----Original Message----- From: Tavmjong Bah [mailto:tavmjong@...8...] Sent: zondag 27 september 2009 21:17 To: the Adib Cc: Inkscape Devel List; Ted Gould Subject: Re: [Inkscape-devel] Call for Pre3
On Sun, 2009-09-27 at 18:05 +0200, the Adib wrote:
Tav,
from my standpoint your patch is (mathematically) not correct. The geometrical epsilon is not related to mathematical
significance.
The epsilon must be considered somewhere else but not in matrix_inverse operation. I attached a (similar) patch and more explanation in
the launchpad.
HTH, theAdib.
You won't get any argument from me that what you did is
correct. I
was just aiming to get something in that was better than what was there without having to understand why EPSILON was being
used in the
first place. Thanks for getting in pushed through.
(Now if we can only get Export to OCAL disabled I'll be really happy.)
Tav
Come build with us! The BlackBerry® Developer
Conference in SF,
CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
-------- Come build with us! The BlackBerry® Developer
Conference
in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile
applications
to market and stay ahead of the curve. Join us from
November 9-12,
- Register now! http://p.sf.net/sfu/devconf
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel