25 Mar
2014
25 Mar
'14
12:03 a.m.
On Mar 24, 2014, at 3:07 PM, Krzysztof Kosiński wrote:
It looks OK, no amendments necessary.
I'm not 100% sure about the "hybrid" variant which takes the key as char const * and the value as Glib::ustring, but this is a common occurrence in the codebase, so I guess this optimization is justified.
Johan, can you take a look at that? Normally I'd expect an implicit conversion to come into play and the compiler to wrap char const* params in a Glib::ustring instance. That definitely is the usual behavior with std::string.
The main gotcha would be if we are passing NULL into any of those calls as an expected use pattern.
However... there is enough there that I'll give it another look. I think a few things can be tuned up.