On Fri, 2010-03-19 at 16:48 +0100, ~suv wrote:
On 4/2/10 20:59, Joshua A. Andler wrote:
On Wed, 2010-02-03 at 19:10 +0100, Martin Sucha wrote:
Hi all,
I've implemented feature to automatically group objects when setting clip/mask and it now works for me. (Thanks Krzysztof Kosiński for help.)
Could you please review attached patch and commit it if you consider it good enough?
Reviewed and tested, looks good by me (and is something I will use). Committed in bzr rev 9050. Thank you!
Is it possible that this patch introduced a big performance loss when grouping a larger selection of objects? I just stumbled upon this when clipping ~1800 small objects (created with the spray tool) with a rectangle using the new feature to group the selection automatically before applying the clippath to the group: to my surprise this took very long (~45 seconds) whereas grouping the same selection happens almost instantaneously in Inkscape 0.47 (~2 seconds).
This appears to be accurate... would you mind filing a bug report and assigning to Martin Sucha?
Unfortunately, there is no way we can release with this big of a performance hit for such a common task. So if it doesn't get fixed before Feature Freeze I will have to revert it.
Cheers, Josh