14 Sep
2013
14 Sep
'13
7:04 p.m.
- There are several coding style problems:
- Whitespace does not conform to coding standards. We always use 4 spaces as the indent, while some of the files you've changed have inconsistent indent (sometimes 4 spaces, sometimes 1 tab).
- We always write the reference and pointer signs attached to the variable name, not the type name.
- We qualifiers such as const after the type name, not before it, because they bind to the right.
Okay, I'll look into that. Although I'm sure that most of the style issues existed before I touched the files ;) .
- SP_IS_TYPE() macros should be implemented as a comparison with NULL, so that you can't assign the result to a pointer. SP_TYPE() macros should be reimplemented as dynamic_cast so that they generate compile-time errors when something not derived from SPObject is passed.
Okay. We have to be careful, though, as dynamic_casts add some runtime overhead. After some more refactoring steps we hopefully can omit most of these type checks.
Other than that I haven't found any significant problems yet; the code looks mergeable. I'll complete the review today or tomorrow.
Sounds good.
As for the static library: If someone complains we can think of something else :) .
Regards, Markus