2013/6/14 Martin Owens <doctormo@...400...>:
Hey Lauris,
I'm fixing https://bugs.launchpad.net/inkscape/+bug/166327 and I have to commit code which goes directly against your comment in the code:
787 /* We do not allow ungrouping <svg> etc. (lauris) */ 788 if (strcmp(group->getRepr()->name(), "svg:g") && strcmp(group->getRepr()->name(), "svg:switch")) {
Since I'm enabling the ungrouping of svg elements, I have to ask why we may not want to be able to upgroup svg elements. Should we check for element->parent != NULL here to make sure we don't ungroup the top-level element by mistake?
I think that back when this code was written there was an assumption that there is only one <svg> element in the document, the topmost one. Naturally this is no longer the case.
Regards, Krzysztof