-----Original Message----- From: Michael Wybrow [mailto:Michael.Wybrow@...2349...] Sent: 27 October 2010 05:46 To: ~suv Cc: Inkscape Devel List Subject: Re: [Inkscape-devel] 0.48.1 next week
On 26/10/2010, at 6:47 PM, ~suv wrote:
Any chance you could take a look at another regression? Bug #591586 "[connectors] 'z' segments closing a path are ignored" https://bugs.launchpad.net/inkscape/+bug/591586
Due to changes how the closing segment (z) is stored in the path
data
in
0.48, connectors ignore the closing segment of paths and shapes if
it
is
a straight line (still present in r9854 and the 0.48.x branch).
This appears to be a problem with 2geom's path crossing-detection
code.
Basically, the crossing detection code seems to be ignoring the final line segment of closed paths. As far as I could understand the 2geom code, this is possibly due to the bounds() function in
2geom/crossing.h
using Path::size() which will be equivalent to Path::size_open()
rather
than Path::size_default() (which calls Path::size_closed() for closed paths).
Could familiar with 2geom's crossing detection code, or Krzysztof (who authored the closing segment changes), please have a look into this problem and find the correct way to fix it? The bug report above
shows
the symptoms.
Krzystof did not author the closing segment changes, and is not to blame. It happened when we switched our geometry calculations to lib2geom, so blame me. I'll look into the issue hopefully this evening. It could indeed be as simple as the fix you suggested; thanks for finding that.
Ciao, Johan