On Mon, 2005-01-03 at 04:46 -0600, Bob Jamison wrote:
Does the file really need to be broken up?
I think so, yes.
We are already using the IconFactory
Only for the old .xpm icons and not in any standard fashion.
The sp_icon_new_* family of functions have nothing to do with IconFactory, and are used by Sodipodi/Inkscape "propriety" methods of handling things like icons in menu items and toolboxes, etc.
The way it'll be done in the Gtkmm code will be 35,000% more clean and correct.
With the Gtkmm wrapper of IconFactory, it would seem to be easier to do this wedge in Gtkmm with a simple subclassing than is already done in Gtk/C. A little bit of C++ coding by a couple of people could save many hours of work for many others.
I didn't imagine that writing a script to explode icons.svg into its separate files would be that complicated. I mean, Inkscape already does some fashion of this in C using Inkscape's render.
The only problem right now with porting sp_icon_image_from_svg() to the Gtkmm codebase and its use of IconSource/IconSet/IconFactory is that the Gtkmm code doesn't yet have the Inkscape renderer.
All I can do right now in the Gtkmm code is have GTK+ load each icon separately based on filename and have it automagically rendered via librsvg where ever its required according to the StockID it's associated with.
Besides, parsing icons.svg complicates the code quite a bit more than simple repeated calls to IconSource::set_filename().