bulia byak wrote:
On the save dialog, it is under "Browse"
That seems like a very strange place to put it.
Well, not really, actually it's where it should be - at the top of a file browser list. It's only that the entire file browser including preview is now folded by default (but that's OK with me).
With regard to save dialog, I see two problems now:
1 Pressing Enter in the filename field does not activate save (very annoying)
This item is private. This might not be possible to change.
2 By reusing the same file type list as in Open, we have effectively removed the possibility of saving in any format other than SVG (even SVGZ). If you want to save in some other format, first you must guess to open the "browse folders" pane (why?) and then you must guess that the list starting with "All images" actually controls your save format. Both of these guesses are highly counterintuitive.
When the dialogs are created, the desired type is passed to the constructors: OPEN, SAVE, IMPORT, EXPORT. This could be used as a switch during filter generation to get what is desired. The menus are not accessible directly. We create and add FileFilters.
Also, note that when the RESPONSE_OK is received after showing the dialog, we query which filter was selected, and lookup the Extension from that. So, if the user picked a file type that is not one of the aggregates (All 'blah') , then we do know what type was desired, and we might be able to use it. It would be good if the API returned the info "which pattern listed this file type?" but that would be dreaming.
Here's what I think must be done:
- move the "Append extension" checkbox right under the "Name:"
This is an API thing. I do not think that it can be moved. However, we can -maybe- (maybe not) have the "extra widget" allowed by the api to be a panel that stretches the width of the dialog, and align the checkbox on the right. This might take some investigation/playing.
- to the right of it, add a new drop-down menu "Format:
[SVG|SVGZ|...]" - this will control the format
Same thing.
- before the "All images" list in the filebrowser, add "Show:" label
(both in save and in open dialogs) - this will only affect what is shown in the list, not save format
Maybe the same thing, too, as the right of the panel would be near the filter list.
Changing the topic a bit.... maybe someone can look at the export dialog (export.cpp, not filedialog.cpp), and see how it could be updated.
And thanks for fixing the "No preview" thing. Looks nice.
I have a software delivery this week for the "day job", so I will not be able to work on this for a few days.
Bob