Hi Alex,

did you have time to look into the first regression yet?

I appreciate you trying to remove deprecated code, but I'd very much prefer if it wouldn't break existing functionality...
I admit code that compiles without warnings makes developers happy, but code that actually works seems to be the more important goal as it makes everybody happy and would help to counter the bad reputation Inkscape already has with respect to regressions. :-/

Hope you find the time to look into it! (If you don't plan to work on it it would be nice if you could at least let me know)
Eduard


Am 06.07.2017 um 22:28 schrieb Eduard Braun:

Hi all,

first of all I'd like to thank everybody for their contributions during the hackfest!

As with all new code I noticed some regressions. As you probably know best on what parts of the code you worked yourselves I'll just list everything I noticed here, so you know about it and can attempt to fix it. (If I need to file a bug for any of those please let me know, but I hope most of those issues can be fixed easily):

  1. The Inkscape Window is not restored to the correct position anymore (probably related to https://gitlab.com/inkscape/inkscape/commit/fa8a2ee7e2539b145a87ac9af0d9748effa91631).
    On a multi-monitor system with two monitors oriented like [1][2] with [2] being the primary monitor the Inkscape window is restored somewhere on [1] if it was closed on [2], so probably the combined screen area is not accounted for when calculating positions.
  2. Some icons are broken or missing, see https://inkscape.org/de/gallery/item/11147/broken_icons.zip (there might be others, but those are the ones I noticed).
  3. During the hackfest menu icons were re-added. However on Windows I was only able to find them in a single location (the path menu). Aren't there supposed to be more icons?
    Also they look a bit weird (see https://media.inkscape.org/media/resources/file/menu_icons.png): Instead of using the space to the left they are indented like the rest of the text shifting menu labels unnecessarily to the right resulting in a very uneven look.

If I notice anything else I'll report it here.

If I can provide additional information or help with debugging please let me know.

Regards,
Eduard



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


_______________________________________________
Inkscape-devel mailing list
Inkscape-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/inkscape-devel