On Tue, Feb 26, 2008 at 11:22:16AM +0100, Marcin Floryan wrote:
Hi!
I was trying to review bitmap effects and found two where translation is not used properly.
In /src/extension/internal/bitmap there are two files: addNoise.cpp and channel.cpp where strings are properly marked for translation (and thus are in the .po files) but do not appear to be used. I thought it would be nice to fix this for 0.46 since the strings are already there but I can't trace where the XML is used to create the UI. It seems like the items for Combo Box are not being created with a call to gettext.
This could potentially benefit more then just those two effects and would also allow for the combox box items in the idx files to be translatable.
If it fixes a detectable bug in the UI, and requires no string changes, it would definitely be a candidate for inclusion. However, if it turns out that further work is needed to get things hooked up properly, it would be best to leave for 0.46.1 or 0.47.
Bryce