
31 Jul
2013
31 Jul
'13
8:13 p.m.
On 31-7-2013 21:05, Markus Engel wrote:
Okay, I'll fix that now... I know that there is still some things left to do, e. g. turning some methods into member methods. But actually, I didn't notice any obvious bugs and keeping all the work in a separate branch gets quite difficult for me when there are so many people making changes to the files I modified. I will of course further refactor the classes I started with :) .
Yeah, refactoring in a branch for too long is nuts. I agree with Josh that it's fine to merge into trunk if you think it's ready. For you, I think the sooner the better.
Cheers, Johan