On 14-1-2014 23:21, insaner wrote:
awesome, thanks for the quick feedback. I have made all the changes you suggested and posted the patch there. Out of curiosity, why no tabs?
Tabs mess up the indentation, I think mostly because people use different tab sizes. (it's hard to use them properly so that they do not mess up) So, to solve that once and for all, we decided a long time ago to not to use any tabs.
Actually, there is some non-conforming indentation in your patch. Please indent with 4 spaces (not 8), and indent the body of an if-statement: if (a) { hoi; } It's nit-picking, and does not solve the bug. But it makes reading the same code in half a year from now much easier.
Something we should try to remember and fix some day: the new_id generating/finding code should be split-out into a new function; it's useful to have. Can you add "/// \todo" (or something doxygen eats) when you commit? Thanks!
also, can you take a look at the iconv problem? I really don't know about build tools enough to come up with a solution I can be confident in.
Hmm, not now, and tomorrow I have forgotten about it ;-)
cheers, Johan