I had a look on the set property of the SPIPaint structure, and I noticed it is only used as a bool, while this property was defined as an unsigned integer. This is not a good programming practice imho.
This results in comparing this integer with an a boolean in amongst others desktop-style.cpp line 505. Is this desirable?

> Revision 12297 changed several bitfields in SPStyle to bool and unsigned int.
As far as I can see only one field is changed from unsigned integer to bool, so the SPIPaint memory size should decrease. Unless, I overlook something in the code. In that cas, I'd be happy to learn something new. ;-)

Regards, K.


2013/4/22 Krzysztof Kosiński <tweenk.pl@...400...>
Revision 12297 changed several bitfields in SPStyle to bool and
unsigned int. This means that the size of every SPStyle object will
increase by at least 16 bytes. What is the motivation for this change?

Regards, Krzysztof Kosiński

------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Inkscape-devel mailing list
Inkscape-devel@...1794...s.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/inkscape-devel