On Sat, 2004-09-25 at 15:16, bulia byak wrote:
By the way, do your newly added commands for moving layers up/down in z-order work correctly with such group-layers? I think they should move the group you're in relative to the adjacent objects even if these objects are not layers. Do you agree?
I think so. In principle I think they should work for "honorary layers" as implemented, since the code doesn't check whether the current layer is a "real" layer or not. It just obtains an SPObject * from SPDesktop::currentLayer() and runs with it.
I've not tested though.
This would work the same as the regular z-order change commands on objects, but apply to the (temporary or permanent) layer. In fact, you can use those commands for it with a few modifications. Note that they move 1 step up/down relative to the objects that the selected object (or, in your case, layer/group) overlaps; I think this also makes sense to preserve for moving group-layers.
? could you elaborate?
One other group of verbs we need is for moving a currently selected object to the next/prev/top/bottom layers. If several objects in different layers are selected, they're first sorted together in z-order in the layer of the topmost (for moving up) or bottommost (for moving down) layer, then the entire stack of selected objects is moved to the top of the next/prev/top/bottom layer. It should display something like "<b>10</b> objects moved up to layer <b>Layer1</b>" in the statusbar.
By the way your current "Move to next/prev layer" commands must be renamed. They don't _move_ anything, they _switch_ the current layer. A helpful statusbar message would be "New current layer: <b>Layer1</b> (at <b>2</b> of <b>5</b>)".
Well, the intent is that they will eventually move objects just as you describe. I just haven't implemented that part yet.
I'm still not sure whether we would really need a separate command for simply switching layers or not.
And the commands moving the layer in z-order should display, "<b>Layer1</b> is at <b>2</b> of <b>5</b> (moved up)" or "<b>Layer1</b> is at <b>1</b> of <b>5</b> (<b>not moved</b>, cannot move any further down)".
Ok.
One more thing: when you update any shortcuts, please edit doc/keys.xml to reflect this (I could do this myself, but it would be useful to have at least one more developer familiar with that file :) Use <note>s to describe any non-obvious aspects of the commands.
Hmm, ok.
-mental