Ok thanks for the feedback... I expected that this would be a can of worms, so I'm glad I checked!
I'll go ahead with migrating the existing widget to a tool-item derivative so we don't lose any of the existing functionality.
AV
On Mon, 11 Feb 2019, 19:55 Bryce Harrington, <bryce@...961...> wrote:
On Mon, Feb 11, 2019 at 03:14:53PM +0000, Alex Valavanis wrote:
Hi Tav and devs,
I'm currently looking into getting rid of the deprecated GtkAction usage
in
the TextToolbar. It seems that the only sticking point is the use of the Ink_ComboBoxEntry_Action widget to select fonts.
It should be OK to migrate this to a Gtk::ToolItem, but before I do
that, I
just wondered if we had considered using the standard GtkFontButton ( https://developer.gnome.org/gtk3/stable/GtkFontButton.html)?
This would provide a summary of the font face and size, but would pop-up
a
font-chooser dialog (
https://developer.gnome.org/gtkmm-tutorial/stable/sec-font-chooser-dialog.ht... )
rather than providing an entry in a combobox. This could result in a
less
cluttered toolbar, but I suspect there might be some "clever things" going on in our font support, and I don't want to break anything without asking!
Any thoughts?
Like Tav and Patrick mentioned, there's been a lot of customization work of the font selector toolbar and dialog, and given that this is heavily used by our userbase, even small behavior reductions may generate a lot of complaints. This is an area to be especially cautious with.
Are there any behavioral improvements that GtkFontButton would provide over our current widgets?
Bryce