Maximilian Albert-2 wrote:
Ah, okay. I hadn't noticed this patch, thanks for pointing me there. I won't apply it, though, since I don't have any expertise in this area and cannot review it.
I had a look at the patch, and I think we should NOT commit it even after the release:
1. It introduces an additional runtime dependency (libneon); moreover this additional dependency is completely redundant, because accessing FTP, HTTP and WebDAV can be done in a more high level way using GIO which is already in our deps (as part of Glib), and we do not need to care about a lot of boring things like asking for login credentials.
2. It tries to access remote locations using derived versions of standard C++ library stream buffers with a 4KB buffer size, I don't think this is a good idea :/ Moreover very few people know how to properly subclass an std::streambuf.
3. Uses non-portable code in streams-handles.cpp: this file includes unistd.h, sys/socket.h, sys/types.h and netinet/in.h; some of those are not available on Windows, or include different functions.
4. Not directly related to the patch, but if the author wants to rename Inkscape::XML::Document to Inkscape::XML::DocumentTree because he gets conflicts with the SPDocument he renamed to Document in the global namespace, then he has no idea what he's doing :( The change from Inkscape::XML::Document to Inkscape::XML::DocumentTree is counter-productive because that object represents an XML document, not some 'document tree'.
Regards, Krzysztof