Christoffer;
What is bad with git submodules in your experience?
Mvh
/Olof ----------------- Är du systemutvecklare? Spana in https://cilamp.se
On 10 June 2017 at 20:12, Christoffer Holmstedt <christoffer.holmstedt@...400...> wrote:
My experience is that git submodules are really cumbersome to work with. Duplication of code is not nice but if sanitizers-cmake is no available as a system package maybe it is just easier to copy the files to Inkscape repository.
2017-06-10 16:45 GMT+02:00 Jabier Arraiza <jabier.arraiza@...2893...>:
Thanks Michael, deviation between debug/release is boring! Best!
On Sat, 2017-06-10 at 15:28 +0200, Michael Soegtrop via Inkscape-devel wrote:
Dear Inkscape Team,
since gitlib is up and running, the question arizes if we want to use submodules, and if so which folder structure should we use.
I want to add address / memory sanitizer support and use https://github.com/arsenm/sanitizers-cmake. It is just a few files and I could copy them verbatim, but it would make sense to add it as a submodule.
In case you don't know what address/memory sanitizer is: it creates instrumented builds (about 2x slower) which check for all sorts of invalid memory usage, like access to freed memory or reading uninitialized variables. The cmake scripts above enable this by a cmake define, similar to switching between debug and release builds. In my experience it saves a lot of time in tracking down obscure bugs in complex C++ code. I right now have a debug/release deviation I want to track down.
Best regards,
Michael
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
-- Christoffer Holmstedt
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel