bulia byak wrote:
Jon,
It's good to see the swatches being worked on. Shift+click now works, which is excellent. Some comments:
- please remove the padding between the swatches (not only does this
waste space, but also makes the colors harder to discern due to a well-known optical illusion)
Sounds good. Should this be only in grid mode, or in list mode also?
- please make it remember the display mode and the loaded palette
across sesssions (and the window size/placement too, of course)
This goes along in with the PanelManager/dialog retune.
- please do something with the menu and X buttons, they are rather
ugly (why don't you just copy them over from Gimp, they're nice there)
Yes, I know. They are majorly ugly. Just temporary. The main problem is that to get things going well takes quite a bit of coding if we don't want to switch to GTK+ 2.6 (which we don't).
- please fix it to not display the scrollbars when they are not needed
This goes in with the Panel/Dockable/DockFillable rework.
- could you add a "no color" button to the beginning of each palette,
which would set "none" to either fill or stroke
Nope.
:-P
That's not a color. That's a style attribute. So that will fall under the style swatches/picker. Not sure how long it will take before that gets some work, so I'll look for places to put things in UI.
- what is eek-preview.cpp? is it temporary? if not could you please
rename it to something more useful?
Well, it's a preview widget that needed some 'collection' name prefix. I kept asking for better suggestions than 'Foo' for that, but nobody spoke up. It's part of a set of planned things that will be self-contained, low-level, reusable widgets and objects. One thing to go in there is a Color object that knows how to deal with more than just pure RGB(A). An abstract 'style' object is another, and then a widget to display one or more styles (the fill/stroke status display widget).
Anyway, I figured that "Eek" was a bit better than "Jon's" or "Foo", so went that for now (I also avoided 'Ink' since I want them reusable, and that things like 'InkColor' start to carry a misleading connotation). If you can think of a better short prefix, let me know.