On 4-10-2013 18:30, Krzysztof Kosiński wrote:
https://bugs.launchpad.net/inkscape/+bug/1234216 - large perfomance regression https://bugs.launchpad.net/inkscape/+bug/1235279 - loss of precision
These problems should be addressed soon, or the unit-related work might need to be reverted before release.
The concept of using a viewBox that makes user units equivalent to inches or other large units is severely broken, because currently we use only 6 digits of precision for all coordinates. That was sufficient for pixels, but is definitely not sufficient for a lossless conversion between pixels and inches.
The performance regression is very serious indeed. To start cleaning/speeding up the code: I changed the Units code to no longer new Unit objects, which was causing huge memleaks all over the code. After my change, a "unit" variable most commonly is a pointer to a unit object in the UnitTable. I've commented-out the method that deletes Units from the UnitTable, for safety.
Cheers, Johan