29.04.2016 7:01, Dmitry Zhulanov пишет:
28.04.2016 9:38, Martin Owens пишет:
On Thu, 2016-04-28 at 09:13 +0600, Dmitry Zhulanov wrote:
All yaml parser sources taken from official page http://pyyaml.org/wiki/LibYAML and I put them to src/yaml This is what you should not do.
Keep the library separate and include it as needed. Inscape uses many outside libraries and libraries should NOT be included in the branch.
dynamic linking of libyaml, fix up code style, remove unused code, update to latest inkscape repo version remove printfs, remove commented garbage,
I agree, all of this should be done before patch would be accepted.
... and forgot to say Im must complete migrate my game data to xverb version of inkscape, then I return to listed patch improvements. I have to be sure nothing is missed. And of course running game is a good test case for this patch ;)
Best Regards, Martin Owens
Best Regards, Dmitry Zhulanov