On Mon, 6 Nov 2006, bulia byak wrote:
Date: Mon, 6 Nov 2006 21:40:29 -0500 From: bulia byak <buliabyak@...400...> To: Jon Phillips <jon@...235...> Cc: Inkscape Development Mailing List inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] [Fwd: [Inkscape-tracker] [ inkscape-Patches-1591552 ] stringfix: s/Add Layer/New Layer]
On 11/6/06, Jon Phillips <jon@...235...> wrote:
Should I accept this patch? It is a stringfix for consistency between gimp and inkscape and layers...
It makes the menu inconsistent with itself. All other commands are verbs but this one is not.
"Layers..." is most certainly not a verb, and that side steps the more important underlying question of improving consistency.
Inkscape already breaks all kinds of standard conventions and style with the current long wordy and repetitive labels.
Besides, if the patch changes that, it must also change the title of the "Add layer" window.
The next patch can change that, incremental improvement is the name of the game. The patch was intended to be better than just a suggestion on the mailing but you are welcome to submit a more comprehensive patch. It is unreasonable to expect more complicated patches and up front time investment if there is not a good chance of them being accepted, and the patch first ask questions later policy never seems to apply to my suggestions. If I were to submit a more detailed patch would very likely include the shortcuts Ctrl+Shift+N for creating a new layer, which would make the current label even more incongruous.
I submitted the patch in response to a discussion on the user list which pointed out other inconsistencies such as the icons in the Layer menu being different from those in the Layers dialog. Again the underlying issue is consistency with what users expect from other programs.