Felipe,

I approved you to be in the Inkscape group. I'd think that anyone should be able to see their own PR's, but that might solve this most immediately.

Ted


On 06/09/2017 05:22 PM, Felipe Sanches wrote:
That page is a 404 for me :-P

2017-06-09 18:49 GMT-03:00 Maren Hachmann <maren@...3165...>:
I guess you need to subscribe to get them (I am not subscribed).

Your merge request is available at
https://gitlab.com/inkscape/inkscape/merge_requests/1

Maren

Am 09.06.2017 um 23:21 schrieb Felipe Sanches:
> i'm used to the "pull request" workflow on github. It seems to me that
> the analogous workflow on GitLab would be the "Merge Requests".
>
> I forked the Inkscape git repo into my personal GitLab account here:
> https://gitlab.com/fsanches/inkscape
>
> Then I created a feature branch challed *variable_fonts* where I'll be
> working on the OpenType Variable Fonts feature.
>
> But I also created a feature branch specifically for a single-commit
> merge request. The code itself is very very simple. The idea here is
> just to exercise the workflow. The branch is called
> *disable_libnrtype_debugging_code* and you can see it here:
> https://gitlab.com/fsanches/inkscape/commits/disable_libnrtype_debugging_code
>
> Then I opened a "merge request", but it failed to give me any success
> screen. Once I tried doing it for the second time it gave me an error as
> can be seen on the attached screenshot. It says:
>
>
>         The form contains the following error:
>
>   * Validate branches Cannot Create: This merge request already exists:
>     ["Disable debugging code on libnrtype Layout-TNG-Compute at
>     compile-time."]
>
>
> But when I look at Inkscape's GitLab repo dashboard, I cannot see any
> mention on open merge requests. I'm a bit puzzled about it.
>
> Did anyone receive an email notification about it ?
>
> Happy Hacking,
> Felipe "Juca" Sanches
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> Inkscape-devel mailing list
> Inkscape-devel@...1784...sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Inkscape-devel mailing list
Inkscape-devel@...1784...sourceforge.net
https://lists.sourceforge.net/lists/listinfo/inkscape-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


_______________________________________________
Inkscape-devel mailing list
Inkscape-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/inkscape-devel