W dniu 5 sierpnia 2010 09:28 użytkownik Jon Cruz <jon@...18...> napisał:
One note, though. I see that the patch is using a "MAX" macro. Now that Inkscape is using C++, we should try to use std::max() instead. Hmm... and the placement of the "+ 1" outside of the max seems a little odd.
I have a suspicion that either MoveWindow breaks when the width is the same as before, or GetWindowRect returns bogus values. The "+1" is to avoid the first case.
Oh, and now that I think of it, if it is helpful to cap the width, it might also be handy to watch the height. That's one area where GTK programs get dinged for not respecting the current dynamic 'usable' area, etc.
Height was not a problem in the bug report, but it might make some sense to add it. I think that native dialogs should be removed in 0.49 because they are a maintenance nightmare, and make implementing features like the "embed" checkbox in the import dialog more difficult than it should be.
Regards, Krzysztof