Maximilian,
thank you so much!
In my opinion to simply put namespaces into the codebases in this stage of the project is not adequate. This can wait until after 0.47.
Adib. ---- PS Maximilian: Ich freu' mich, wieder was von dir zu hören :-)
On 8/6/09, Maximilian Albert <maximilian.albert@...1439...> wrote:
2009/8/6 Jon A. Cruz <jon@...18...>:
Ah, seems quite simple. Here is the root problem:
r21994 | johnce | 2009-08-05 11:32:38 -0700 (Wed, 05 Aug 2009) | 1 line
xml/Document -> DocumentTree
It appears that someone renamed the struct in the .h but did not rename it in forward.h, and did not change the usages of it.
I spent the better part of four hours trying to fix this (because each change broke things at other places) and finally ended up with the discovery that there are some #includes in file.(h|cpp) (namely, streams-webdav.h and friends) for which the corresponding files are missing. Thus I decided to revert the recent set of changes by johnce, also because I'm not sure it's a good idea to have such huge commits so close to the release. If I overlooked something and there is an easy fix please feel free to undo my revert.
BTW, during my fixing attempts I partially had to revert changes made by johnce because Document (formerly known as SPDocument) and Inkscape::XML::DocumentTree (formerly known as Inkscape::XML::Document) got mixed up in his latest commits. So it seems to me that there may be quite a few places where bugs might be introduced by these commits. I don't know what others think about it, but IMHO it would be better to hold them back until 0.47 is out. Don't get me wrong, I believe that the changes are valuable and the renaming can eliminate potential sources of confusion, but it's just too dangerous to apply them now. Opinions?
Max
@johnce: Please always make sure to only commit changes which don't break the build! I had planned to work on some other things tonight but essentially spent the whole evening trying to fix compiling so my pending work will have to wait until I can spare some more time (which may only be in a couple of days if I'm unlucky).
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel