On Friday 19 March 2010 19:16:35 Martin Sucha wrote:
On Friday 19 March 2010 18:40:26 Martin Sucha wrote:
On Friday 19 March 2010 17:38:15 ~suv wrote:
Bug #542004 https://bugs.launchpad.net/inkscape/+bug/542004 “performance regression when grouping a large selection set”
Interesting. I changed the code so I could reuse grouping from clipping function, but the logic behind grouping should be the same. Looking at the patch, I suspect the call to selection->clear() should be before the whole grouping logic (it was before) and I accidentally put that after. Will check if this causes the regression.
Yes, this causes the regression. I fixed this for grouping and now I'll look at the clipping code as it needs to be adjusted as well. Will send a patch when done.
I've attached the patch to the bug report (#542004). Could you please try that? I tried to test all possible code paths, however, I don't know how to apply a clip on layer so please test it and/or tell me how can I do that.
This patch moves selection into list so hopefully I've got that right. I don't know if I managed to maintain the selection order (for clipping and removing clip), though; how to test the selection order and whether it is an issue.
Additionally, I also fixed a performance problem (related to selection) that is present in 0.47 - it shows when you ungroup a group and have selected a lot of non-group objects as well.
Regards, Martin Sucha