On 9/2/07, Ted Gould <ted@...11...> wrote:
On Sun, 2007-08-26 at 10:36 -0500, Christopher Brown wrote:
> I don't have SVN commit privileges, so Ted Gould has just been
> uploading the code I've produced for me. The final code, though, has
> not made it into SVN yet because Ted is away from home for a few
> days.

I plan on working on this this week.  Who knows, LA may just melt this
week though :)

> I took convolve out because I couldn't figure out how it's supposed to
> be used. The codefiles are still in the source, but they're not loaded
> into the menu.

I think this might still be useful.  I'm a DSP freak though -- so it may
be to just me ;)

Okay, I'll try to figure it out.

> 1. You're right, flop ought to be taken out.
> 2. & 3. I'll ask Ted about this -- I don't know how to make strings
> translatable. I think that C++ effects should be able to use the same
> format of .inx files as the Python/Perl/Bash effects, but I wasn't
> able to load external effect definitions for my effects.

For the INX files that are built into the codebase you'll need a _()
surrounding the strings to be translated.

Okay. Might take awhile, but I can do that. 

> 4. Like convolve, I couldn't figure out what Threshold was supposed to
> do. Even using ImageMagick via the command line "convert" I couldn't
> make sense of it.

Take it out then?  Anyone object?  Chris, do you think it makes sense to
e-mail the Imagemagick lists on this?

I guess I sort of know what it's supposed to do -- it's supposed to convert every pixel above the specified intensity to white and everything below to black. I just couldn't get it to do that. I can look into this too -- school doesn't start until the 5th. 

> 6. All the effects use the same extension framework, so if this is
> agreed on, it will be a matter of minutes to go through the
> paramcolor.cpp, paramint.cpp, paramfloat.cpp etc. files and add a
> colon after the parameter labels.

This is an interesting point.  Should we do this globally and take it
out of the INX files?  Would that be easier or harder to translate?
Does every language use ":"?

Personally I never found the lack of a colon hard to understand, but for solidarity's sake, I can insert colons when I go through with the _( )'s, if that's what's needed.

-Christopher