On Sun, 2005-01-30 at 23:30, bulia byak wrote:
Mental, this is yours again. In desktop-style.cpp, this checks if the repr has no attributes:
if (((SPRepr *) css)->attributeList() == NULL) {However attributeList() returns non-NULL even if there are no attributes. Please either fix it to return NULL as before (preferable) or provide a new function e.g. bool attributeListIsEmpty().
... What. The. Heck?
this used to be:
if (((SPRepr *) css)->attributes == NULL) {
And the only change I made was to move SPRepr::attributes to SimpleNode::_attributes, and implement SimpleNode::attributeList() thusly:
SPReprAttr const *attributeList() const { return _attributes; }
If there are no attributes, attributeList() should BY DEFINITION return NULL.
I think you're right that whatever is going on here is a likely source of the PPC/AMD64 crash anyway...
-mental