On 23-3-2014 14:51, Markus Engel wrote:
:) Actually, clang has already output this warning a year ago, but I never managed to look into this... gcc did never complain. You should probably get a few different environments (clang with -Weverything ;)) so you can fix even more warnings...
I so desperately want to build with clang on Windows... :'( :'( :'(
In many places I'm just not sure whether these things are intended. Let's say ../../trunk/src/live_effects/lpe-powerstroke.cpp:611:104: warning: implicit conversion from 'double' to 'bool' changes value from 0.01 to false [-Wliteral-conversion] Geom::Path fixed_path = path_from_piecewise_fix_cusps( pwd2_out, y, jointype, miter_limit, LPE_CONVERSION_TOLERANCE);
#define LPE_CONVERSION_TOLERANCE 0.01 // FIXME: find good solution for this.
The last parameter is a bool though. So?
Again you found a terrible bug! I know my powerstroke code needs a LOT of love, but this is really a bad coding bug. The bug here was that the caller things it is setting the tolerance but instead it is setting a bool parameter that is unused, and the conversion tolerance is set to the default value.
See the fix in rev. 13188.
So this was not a false positive at all.
ciao, Johan