Alexandre,
I don't have SVN commit privileges, so Ted Gould has just been uploading the code I've produced for me. The final code, though, has not made it into SVN yet because Ted is away from home for a few days.
Using the final code, on my machine, I tested every effect on Ubuntu and a few on Windows, and they work.
I took convolve out because I couldn't figure out how it's supposed to be used. The codefiles are still in the source, but they're not loaded into the menu.
1. You're right, flop ought to be taken out.
2. & 3. I'll ask Ted about this -- I don't know how to make strings translatable. I think that C++ effects should be able to use the same format of .inx files as the Python/Perl/Bash effects, but I wasn't able to load external effect definitions for my effects.
4. Like convolve, I couldn't figure out what Threshold was supposed to do. Even using ImageMagick via the command line "convert" I couldn't make sense of it.
5. Most of the extensions have a min and max value for the numeric parameters. Do you mean something for the user to read?
6. All the effects use the same extension framework, so if this is agreed on, it will be a matter of minutes to go through the paramcolor.cpp, paramint.cpp, paramfloat.cpp etc. files and add a colon after the parameter labels.
-Christopher
On 8/26/07, Alexandre Prokoudine <alexandre.prokoudine@...400...> wrote:
Hi,
Following raster effects crash Inkscape here (Ubuntu Gutsy Gibbon) on
most recent SVN trunk:
convolve
shade
wave
raise
And a couple of notes:
1. Do we really need flop effect since we can already flip raster
images horizontally and vertically, while flop does it only
horizontally and in a destructive way?
2. Types of noises in "Noise" effect are not translatable.
3. Names of channels in Channel and Level Channel effects are not tranlsatable.
4. Does Threshold actually work? I tried it on several images but
didn't see any effect whatever value I specified (0-100).
5. Should raster effects probably provide some hints to tell range of
possible values for each variable?
6. We seem to use "Variable: [value]" convention in GUI, but no (boh
raster and path) effect uses ":" after name of variable. Should it be
fixed?
Alexandre
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>
http://get.splunk.com/
_______________________________________________
Inkscape-devel mailing list
Inkscape-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/inkscape-devel