Hi,
Sure this patch is wonderful, long awaited! Congrats!
Just to remember: there´s a bug that *should* be fixed as soon as possible. I don´t know if it occurs in mask too, but I´m sure it wasn´t there in 0.46, so, it's a regression.
https://bugs.launchpad.net/bugs/365458
As Granjow pointed in comments, "Isn't this a matter of 10 minutes if you know the code?"
Thanks
On Wed, Jan 27, 2010 at 5:20 PM, Martin Sucha <martin.sucha-ml@...2313...> wrote:
Hi all,
I prefer adding objects into a group before applying a mask, because it allows me to manipulate masked content easily without unsetting mask. But I often forget to group objects before I apply a clip/mask. So I decided to take a look at inkscape source code and made this little feature that does it automatically for me. It needs one more thing to work properly though - when automatically enclosing each object in a group it should mark that group as made by that feature so when unsetting mask it ungroups only those automatically added groups.
So where should be stored some info about whether this group should be automatically removed? There are two possibilities that I think of: either inkscape:groupmode attribute or custom attribute for this purpose
Also, is it sufficient to manipulate those attributes directly or is there any class that takes responsibility for this? At least there is some code managing inkscape:groupmode attribute, right?
I've added a new checkbox in Inkscape Preferences/Clippaths and masks called "Enclose masked objects in groups" to activate this feature (disabled by default to be consistent with previous behavior), so don't forget to check it before testing ;)
As I'm not very familar with C++ or Inkscape source code I hope I've not introduced any memory leaks or crashes. Also if you find any coding style violations, please notify me.
Patch attached.
Any comments are welcome ;)
Best regards, Martin Sucha
The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel