I fixed the crash, but I am not sure whether this introduced a bug somewhere else. (like a dialog not disappearing when it should)
Ted, could you please have a look at this?
Bryce, Josh: could one of you commit this to 0.46 ?
Thanks, Johan
-----Original Message----- From: Adib taraben [mailto:theadib@...1439...] Sent: vrijdag 22 februari 2008 9:51 To: inkscape-devel@lists.sourceforge.net; Ted Gould Cc: Engelen, J.B.C. (Johan); bryce@...1798...; Anhalter42@...173... Subject: Re: [Inkscape-devel] crash on pdf/ps export
J.B.C.Engelen@...1578... schrieb:
... It's fairly traditional to use a NULL pointer to mean "not
defined",
so NULL pointer checks are quite standard and commonly used for controlling when certian logic should be invoked.
True, but in this case, I'm wondering whether it is better
to do the check somewhere else. The function that tests for this NULL does nothing if it is NULL. Since it is a callback function (correct?) that is a reaction on pressing the OK button, maybe this shouldn't have been set as such in the first place.
I'll try to have a look into the other crash.
Johan
I totally agree that this NULL pointer check only prevents from crashing like try and catch block. I think that Teds commit still lacks in something (maybe some initialisation of variables?). But I am not familiar with this GTK functions...
Adib.