On Tue, 4 Jan 2005 16:28:08 -0800 (PST), Bryce Harrington <bryce@...260...> wrote:
Do you want to have wrapper functions by those exact names to hook to those, or do you just want a routine that provides the equivalent functionality?
Does not matter, so long as replacement is obvious you can change the names
functions to get ratios to and from px for all units (to replace the defines from unit-constants.h)
All of the linear document units are based on px as the primary unit so trivially these can be obtained via `u.factor` in the Unit structure.
So, please then provide utility functions like px_per_in() for all CSS units to and from px.
For the unit widget I also added a convenience function for getting the conversion factor from whatever the user's selected to a different unit:
double getConversion(Glib::ustring const &new_unit_abbr) const;
Yep, that's needed too
Basically this just returns old_unit.factor / new_unit.factor but also does some checking that new_unit_abbr exists, and checks that neither factor is ~ zero. Possibly we could promote this convenience function up higher if other areas of the codebase also need to do similar conversions.
Other code normally does not need ratios as such, it needs the value in given units from px or vice versa
Derek and I have crafted a new compound widget called ScalarUnit, which incorporates this functionality a bit more conveniently, and handles the Adjustments internally. To set the value/units for this unit, this function is provided:
void setValue(double number, Glib::ustring const &units);
Good, that sounds similar to the current SPUnitMenu, so should be easy to replace
In addition, if you wish to flip the units, this function can be used:
bool setUnit(Glib::ustring const &units);
will replace sp_unit_selector_set_unit
This will also recalculate the value so it "means" the same thing in the new units.
yes
I assume your code can also attach any number of adjustments to the unit selector, as the current code does?
There will also be signal handlers for unit system changes. That is, if the user changes preferences regarding their units (such as switching the default unit for the document), a signal can be issued and all unit widgets will update accordingly.
That's good, the current code does not do that