On 2-3-2014 22:21, Jon Cruz wrote:
On Mar 2, 2014, at 12:59 PM, Johan Engelen wrote:
On 2-3-2014 19:25, Jon Cruz wrote:
On Feb 27, 2014, at 3:06 PM, Johan Engelen wrote:
On 27-2-2014 23:57, Jon Cruz wrote:
I can take a look at this.
There are a few things that are well overdue for refactoring. We also need to tune things up to not keep so much in memory.
Thank you very much Jon.
Well, I fixed the cleanup with adding a destroy signal to SPDocument... but there are still odd problems in the cleanup of the undo stack. That seems a little more problematic as it is not in the swatches code. Fun.
Thanks for the fix.
I am surprised that SPDoc was deleted at all after adding an extra ref to it in DocTrack. Somehow the refcounting of SPDoc is broken?
Well... I checked the involved code, and the View was actually explicitly deleting the SPDesktop. So refcounting doesn't help if there is an explicit delete.
I think this is another point supporting my initial position on GC: if garbage collection is not part of the language itself, then it is tricky to successfully retrofit.
Can't we make the destructor of SPDoc private to prevent explicit delete? (btw, I think of explicit refcounting as a bit different from GC, but probably that's just me)
cheers, Johan