28 Oct
2008
28 Oct
'08
3:23 p.m.
On Tue, Oct 28, 2008 at 04:00:43PM +0100, J.B.C.Engelen@...1578... wrote:
Please, before committing this kind of patches to svn, check the build on linux *and* windows. Especially on windows for this patch because it involves adding a "#ifndef win32" clause around a whole file.
The problem here is that the compiler on Windows doesn't allow an empty translation unit?
With cross-compiling, we're still using gcc, so we won't catch this unless we compile with -ansi -pedantic-errors (? IIRC)
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v