No, not really, the official installer is a "bit" more complex and has a lot more functionality... Check out the code in the repository if you want to help.

Regarding you code: It's evil ^^
Think about what would happen if you accidentally install to "C:\Program Files" or even "C:\" and then uninstall... The uninstaller would just go ahead and delete everything on the drive. :-0

Here is what I do. Never had a problem so far.

Function un.onInit

!insertmacro MUI_UNGETLANGUAGE

  MessageBox MB_ICONQUESTION|MB_YESNO|MB_DEFBUTTON2 "Are you sure you want to completely remove $(^Name) and all of its components?" IDYES +2

  Abort

FunctionEnd

 

 

Section Uninstall

  Delete "$INSTDIR\${PRODUCT_NAME}.url"

  Delete "$INSTDIR\${PRODUCT_NAME}uninst.exe"

  RMDir /r "$INSTDIR"

  Delete "$SMPROGRAMS\${PRODUCT_NAME}-${PRODUCT_VERSION}\Website.lnk"

  Delete "$SMPROGRAMS\${PRODUCT_NAME}-${PRODUCT_VERSION}\Uninstall.lnk"

  Delete "$DESKTOP\${PRODUCT_NAME}-${PRODUCT_VERSION}.lnk"

  DeleteRegKey ${PRODUCT_UNINST_ROOT_KEY} "${PRODUCT_UNINST_KEY}"

  DeleteRegKey HKLM "${PRODUCT_DIR_REGKEY}"

  DeleteRegKey HKLM "SOFTWARE\${PRODUCT_NAME}"

  ; Remove the path we added (need both PATH and Path?)

  ; ${un.EnvVarUpdate} $0 "PATH" "R" "HKLM" "$INSTDIR\bin;$INSTDIR\Frameworks"  #Remove the Inkscape from the path

  ; ${un.EnvVarUpdate} $0 "Path" "R" "HKLM" "$INSTDIR\bin;$INSTDIR\Frameworks"  #Remove the Inkscape from the path

  SetAutoClose true

SectionEnd

Hope that helps you, Eduard.

Thanks,

Partha

On Mon, Oct 10, 2016 at 6:13 PM, Eduard Braun <Eduard.Braun2@...173...> wrote:

The uninstaller is copied to / run from a temporary directory.
All files are properly deleted (i.e. there are no files left that could block removal of those directories).

Am 11.10.2016 um 00:08 schrieb Partha Bagchi:

Eduard, 

I have not seen your installer (I build my own. :)). You have to delete the uninstaller first before anything. Are you doing that?

Thanks,

Partha

On Mon, Oct 10, 2016 at 6:02 PM, Eduard Braun <Eduard.Braun2@...173...> wrote:

Am 09.10.2016 um 04:17 schrieb Victor Westmann:
> Thank you for your packaged version of the 0.92 pre-release. The
> installer works like a charm (but, for some reason, it pointed
> automatically to the x86 folder, which is for 32 bit software only on
> Windows. But that's fine.

Fixed in r15108 (along with some other issues)
http://bazaar.launchpad.net/~inkscape.dev/inkscape/0.92.x/revision/15108


One thing I can't seem to be able to fix are some leftover empty
directories after uninstallation. Somehow NSIS fails to release a lock
on them during the uninstallation process and prevents itself from
removal subsequently.

Does anybody have some experience with NSIS and knows what might go wrong?


Regards,
Eduard

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Inkscape-devel mailing list
Inkscape-devel@...142...ge.net
https://lists.sourceforge.net/lists/listinfo/inkscape-devel