On 11/30/2016 01:41 PM, Felipe Sanches wrote:
It seems to me that, from the license compatibility perspective that's ok.
I'm not sure, though, if bundling a derivative of a library is a good idea, since it can potentially be left without updates in sync with upstream in the long run.
I could use the original file if I copy two more (very small) headers from ceres, this would mean that Inkscape depends on Eigen (a header-only library for linear algebra).
Making Inkscape depend on Ceres would make implementation of optimization more comfortable and make all that copying unnecessary but building on Windows seem complicated: http://ceres-solver.org/building.html#windows
Maybe your improvements to the library could be accepted upstream first?
Unlikely, I simply stripped the Eigen dependency and removed the ability to calculate higher-order derivatives. The file itself is a very simple file, most parts were written 2012/2013 according to git blame, it's essentially an implementation of a vector with very special rules for operations +-*/ and some functions like exp, tan etc.
Best Regards, Alexander