Hi Jabier,
I'm happy that we're finally making progress towards an icon set that does not just "look nice" (which is highly subjective) but tries to convey additional information using color to actually improve usability!
Is the goal of this merge to land the technical part (i.e. possibility to use customizable colors in icons) or to implement Adam's new icon set?
The former seems fine (especially as it's offering flexibility where we currently have none). As for the latter I'd suggest to finalize (at least the main parts) of the icon set first, then ask for some feedback (i.e. recruit some testers) and improve the icon design accordingly before merging. Right now the icon set seems a bit unfinished, throwing away a lot of it's potential. Getting it right from the start would make it more likely that we could make it the new default IMHO.
Also we were discussing a lot the grouping of the icons during the design process, which is a central part of the concept. However I think this did not make it into the code yet. As it would also benefit all other icon sets (but obviously Adam's in combination with your color-feature most) I'd also recommend to get this done before making the icon set itself "public". Maybe it could even be an independent MR?
Cheers Patrick
Am 25.06.2019 um 19:27 schrieb Jabier Arraiza:
Hi all.
I want to know if is good merge this branch into master. Code wise is done there is only some icons to fix and complete the great collection done by Adam Belis.
Also want to know about defaulting if finished the icon set at time to substitute current default icons.
Here is a video of the feature working: https://chat.inkscape.org/channel/team_ux?msg=xCidGRBhRfSYfyCNM
And here are the MR: https://gitlab.com/inkscape/inkscape/merge_requests/745
Bye!!!! _______________________________________________ Inkscape Devel mailing list -- inkscape-devel@lists.inkscape.org To unsubscribe send an email to inkscape-devel-leave@lists.inkscape.org