23 Nov
2005
23 Nov
'05
5:41 p.m.
Quoting Robert Crosbie <swingincelt@...400...>:
I'm assuming that since sp_repr_change_order always returns TRUE, the proper patch would include removing the variable OK and the assigning and conditional related to it.
Yes. If the function always returns true, then the code would remain semantically equivalent after that transformation.
Also, the last time I looked at these Janitor items, I put some questions in the Wiki. It would be great if these could be answered so that this action item could closed. In particular, whether [the following are to be included in the conversion]:
sp_repr_children
yes.
sp_repr_unparent
maybe... or renamed possibly. I'll have to look at that one tonight.
, sp_repr_document,
yes.
sp_repr_document_root
yes.
-mental