30 Jun
2011
30 Jun
'11
9:06 a.m.
---- Gellule Xg <gellule.xg@...400...> wrote:
I would like to draw your attention on this 2geom commit: http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/10385 Should this be pushed to 2geom?
If you make changes to our 2geom copy, they will most probably be lost on the next 2geom update. So in general, yes you should push your changes to 2geom's repository too.
Specifically about your change; on quick inspection, the " == 0" seems wrong. In 2geom we use "are_near" to check whether floating point values are the same. I remember that the are_near methods use 2geom's default 'nearness' range of 1e-8.
Ciao, Johan