Great, and I just noticed one other thing.

In ocaldialogs.h you have the line
     FileDialogOCALBase(const Glib::ustring &title) : Gtk::Dialog(title,true)

where you call the constructor of Gtk::Dialog. Can you use instead the three parameter
version where the parent window is specified as the second parameter? Like this...

    FileDialogOCALBase(const Glib::ustring &title, Gtk::Window& parent) : Gtk::Dialog(title, parent, true)
This should be pretty easy considering the OCAL classes already get a reference
to the parent window from file.cpp. The advantage of doing this for Windows users, is
that it stops your dialogs sinking down behind the inkscape desktop if someone clicks
on it.
Best regards
Joel


From: "Bruno Dilly" <bruno.dilly@...400...>
Sent: 19 August 2007 10:54
To: joel@...1709...
Subject: Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827] inkscape/trunk/src/ui/dialog


OK Joel, I will do it soon. Thanks for the help =)

On 8/19/07, joel@...1709... wrote:
> I figured out what the problem was now. In my version, I made changes in
> file.cpp, which I managed to miss comitting. I'm very sorry for all the
> inconvenience. I assumed you were asleep, and I was hoping to slip the
> change in quickly before you woke up - well that worked out just great!
>
> On the subject of file.cpp, the line in the current SVN version
> exportDialogInstance =
> Inkscape::UI::Dialog::FileExportToOCALDialog::create(
> was
> exportDialogInstance = new
> Inkscape::UI::Dialog::FileExportToOCALDialog(
> in my version.
>
> Can I suggest that you do the same, when you're ready? There's no need to
> have separate dialog and impl classes in this case. If possible I suggest
> you begin to merge the functionality of the two classes, do away with the
> class factory, and just expose the constructor directly. This sounds like a
> big deal, but actually it only took me about 10 minutes to do.
>
> Hope that helps
>
> Best Regards
> Joel
>
> ________________________________
> From: "Bruno Dilly"
> Sent: Sunday, August 19, 2007 10:09 AM
> To: joel@...1709...
> Subject: Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827]
> inkscape/trunk/src/ui/dialog
>
> But I think I didn't erased any modification.
>
> I just included in the file.cpp you have commited the following itens:
> - an #include "ui/dialog/ocaldialogs.h"
> - the password verification inside the export to ocal function
>
> But if you think is necessary to revert, do it, and I will fix it
> later, if necessary.
>
> On 8/19/07, joel@...1709... wrote:
> > Well it's good that you fixed it. I'm confused though, because I tested
> and
> > compiled my revised version *several* times. Did you guys try running
> > ./autogen ? Now file.cpp needs to be reverted, as my version did away with
> > the class factories.
> >
> > ________________________________
> > From: Jon Phillips
> > Sent: Sunday, August 19, 2007 6:30 AM
> > To: Bruno Dilly
> > Subject: Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827]
> > inkscape/trunk/src/ui/dialog
> >
> > On Sun, 2007-08-19 at 02:11 -0300, Bruno Dilly wrote:
> > > I was doing the same thing as Joel, and I was including the login
> > > dialog used to export to ocal.
> > >
> > > So I commited my ocaldialogs.ccp and ocaldialogs.h, and now things look
> > fine.
> >
> > Whoa, you guys gotta inter-communi-kate ;)
> >
> > Jon
> >
> > > On 8/19/07, MenTaLguY wrote:
> > > > Joel, your recent commit appears to have broken the build.
> > > >
> > > > Please fix it so we can get back to work.
> > > >
> > > > Thanks,
> > > >
> > > > -mental
> > > >
> > > > On Sat, 2007-08-18 at 17:29 -0700,
> > joelholdsworth@...58...
> > > > wrote:
> > > > > Revision: 15827
> > > > >
> >
> http://inkscape.svn.sourceforge.net/inkscape/?rev=15827&view=rev
> > > > > Author: joelholdsworth
> > > > > Date: 2007-08-18 17:29:36 -0700 (Sat, 18 Aug 2007)
> > > > >
> > > > > Log Message:
> > > > > -----------
> > > > > Separated the OCAL import and export dialogs into their own source
> > file - ocaldialogs.cpp and ocaldialogs.h
> > > > >
> > > > > Modified Paths:
> > > > > --------------
> > > > > inkscape/trunk/src/ui/dialog/Makefile_insert
> > > > > inkscape/trunk/src/ui/dialog/filedialog.cpp
> > > > > inkscape/trunk/src/ui/dialog/filedialog.h
> > > > >
> inkscape/trunk/src/ui/dialog/filedialogimpl-gtkmm.cpp
> > > > > inkscape/trunk/src/ui/dialog/filedialogimpl-gtkmm.h
> > > > >
> > > > > Added Paths:
> > > > > -----------
> > > > > inkscape/trunk/src/ui/dialog/ocaldialogs.cpp
> > > > > inkscape/trunk/src/ui/dialog/ocaldialogs.h
> > > > >
> > > > >
> > > > > This was sent by the SourceForge.net collaborative development
> > platform, the world's largest Open Source development site.
> > > > >
> > > > >
> >
> -------------------------------------------------------------------------
> > > > > This SF.net email is sponsored by: Splunk Inc.
> > > > > Still grepping through log files to find problems? Stop.
> > > > > Now Search log events and configuration files using AJAX and a
> > browser.
> > > > > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > > > > _______________________________________________
> > > > > Inkscape-cvs mailing list
> > > > > Inkscape-cvs@lists.sourceforge.net
> > > > >
> > https://lists.sourceforge.net/lists/listinfo/inkscape-cvs
> > > >
> > > >
> >
> -------------------------------------------------------------------------
> > > > This SF.net email is sponsored by: Splunk Inc.
> > > > Still grepping through log files to find problems? Stop.
> > > > Now Search log events and configuration files using AJAX and a
> browser.
> > > > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > > > _______________________________________________
> > > > Inkscape-devel mailing list
> > > > Inkscape-devel@lists.sourceforge.net
> > > >
> >
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
> > > >
> > > >
> > > >
> > >
> > >
> >
> -------------------------------------------------------------------------
> > > This SF.net email is sponsored by: Splunk Inc.
> > > Still grepping through log files to find problems? Stop.
> > > Now Search log events and configuration files using AJAX and a browser.
> > > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > > _______________________________________________
> > > Inkscape-devel mailing list
> > > Inkscape-devel@lists.sourceforge.net
> > >
> >
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
> > --
> > Jon Phillips
> >
> > San Francisco, CA
> > USA PH 510.499.0894
> > jon@...235...
> > http://www.rejon.org
> >
> > MSN, AIM, Yahoo Chat: kidproto
> > Jabber Chat: rejon@...896...
> > IRC: rejon@...897...
> >
> >
> >
> -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Splunk Inc.
> > Still grepping through log files to find problems? Stop.
> > Now Search log events and configuration files using AJAX and a browser.
> > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > _______________________________________________
> > Inkscape-devel mailing list
> > Inkscape-devel@lists.sourceforge.net
> >
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
> >
> >
> >
> >
> -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Splunk Inc.
> > Still grepping through log files to find problems? Stop.
> > Now Search log events and configuration files using AJAX and a browser.
> > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > _______________________________________________
> > Inkscape-devel mailing list
> > Inkscape-devel@...1793...ists.sourceforge.net
> >
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
> >
> >
>
>