bulia byak schrieb:
On Tue, Feb 26, 2008 at 10:02 AM, Maximilian Albert <Anhalter42@...173...> wrote:
if (DESKTOP_IS_ACTIVE (desktop)) { ... }
Well, this check is there from Sodipodi times (actually since the very first version of that file in September 2000, as Sodipodi SVN shows). I have no idea what it is supposed to achieve. Let's test this thoroughly before moving to 0.46. All kinds of scenarios with creating and deleting desktops in different tools and modes should be tested.
I have been doing a bunch of tests by creating new desktops in all tools, both by creating new documents and by duplicating existing views (are there other methods)? Result: No problems at all.
Actually, I think the only question is if there is any scenario when new desktops shouldn't be activated right away. From what I understood by skimming through the rest of the code, they are activated but only a bit later, but the signals emitted are the same and I can't see any reason why emitting these slightly earlier should do any harm. In fact, as the bug shows, the contrary seems to be the case because in the intermediate time some tools may query data from the wrong desktop (namely, the one that was activated before the new one was created).
So in my opinion it should be safe to remove the check but of course further testing should be done by other people.
Max