On Tue, 2013-10-01 at 02:10 +0200, Krzysztof Kosiński wrote:
However, I found a much simpler solution that does not involve touching the shape code. We simply need to update the children of the group before updating the group itself. The fix is in r12643.
Krzysztof, you've saved my bacon on that bug. It was quite hard to understand but you've fixed it :-)
We now only have 3 blockers, one of which is in progress. I'm really hoping that they're actually fixed, but #1005892 might relate to what you were saying before.
What's important to note about the filter_bbox changes is that is all got reverted. The only real difference is the name of the variable. The garbage bbox probably was happening before, I certainly saw weird stuff.
Only the text calculation needs repair if it's getting the wrong bbox. Other shapes don't go through that new enlargement code, just filtered text.
If there is any other object that updates its children after updating itself, it is also broken and needs to be fixed.
If simple tests are working, then we can only wait for bug reports.
HUZZAR!
Martin,