On Fri, Jan 11, 2008 at 12:20:38AM +0100, jiho wrote:
Hi all,
We've just received a patch by Adam Strzelecki that improves Inkscape on OSX, and will probably enable us to make a native experimental build for 0.46. Part of the patch is not directly OS X related and suggests to remove some stuff from toolbox.cpp. In Adam's words:
jiho, the patch seems to be strictly cosmetic, and doesn't look like it'd be required for the OSX port. I'd say exclude it until after the release.
Bryce
- src/widgets/toolbox.cpp: removes tb_s, tb_e spacers from the
toolbars to they DON'T have ugly underlines (who did invent this anyway, this produces ugly look in most GTK themes where toolbars are 2x inset in the GUI, I believe this should be removed anyway in all builds (platforms))
and the part of the patch is:
Index: src/widgets/toolbox.cpp
--- src/widgets/toolbox.cpp (revision 16998) +++ src/widgets/toolbox.cpp (working copy) @@ -630,14 +630,9 @@ { GtkWidget *tb = gtk_vbox_new(FALSE, 0);
GtkWidget *tb_s = gtk_vbox_new(FALSE, 0);
GtkWidget *tb_e = gtk_vbox_new(FALSE, 0); gtk_box_set_spacing(GTK_BOX(tb), AUX_SPACING);
gtk_box_pack_start(GTK_BOX(tb), GTK_WIDGET(tb_s), FALSE, FALSE, 0);
gtk_box_pack_end(GTK_BOX(tb), GTK_WIDGET(tb_e), FALSE, FALSE, 0);
g_object_set_data(G_OBJECT(tb), "desktop", NULL);
g_object_set_data(G_OBJECT(tb), "top_spacer", tb_s);
gtk_widget_set_sensitive(tb, FALSE);
@@ -667,11 +662,7 @@ { GtkWidget *tb = gtk_vbox_new(FALSE, 0);
GtkWidget *tb_s = gtk_vbox_new(FALSE, 0);
GtkWidget *tb_e = gtk_vbox_new(FALSE, 0); gtk_box_set_spacing(GTK_BOX(tb), AUX_SPACING);
gtk_box_pack_start(GTK_BOX(tb), GTK_WIDGET(tb_s), FALSE, FALSE, 0);
gtk_box_pack_end(GTK_BOX(tb), GTK_WIDGET(tb_e), FALSE, FALSE, 0);
g_object_set_data(G_OBJECT(tb), "desktop", NULL); gtk_widget_set_sensitive(tb, FALSE);
@@ -1439,10 +1430,6 @@ } gtk_widget_show(toolbox);
- // need to show the spacer, or the padding will be off
- GtkWidget *spacer =
GTK_WIDGET(g_object_get_data(G_OBJECT(toolbox), "top_spacer"));
- gtk_widget_show(spacer);
gtk_widget_show_all(shown_toolbox);I have no clue about this. Is it safe? Should it be removed or not? Should it do it now or wait after the release?
JiHO
Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel