On Tue, 2014-02-11 at 09:57 -0800, mathog wrote:
On 11-Feb-2014 06:00, Tavmjong Bah wrote:
'preserveAspectRatio' is now set to 'none'; r13023.
Just tried 13024 and on import of images from EMF preserveAspectRatio is not set automatically. When you say it is set to 'none' now in what context does that apply? It isn't a problem adding
preserveAspectRatio="none"to the SVG <image> creation in EMF and WMF, but before doing so, I want to double check that it is not supposed to be happening elsewhere automatically. Presumably a similar line will need to be added to every other file format's image input conversion if it is not to be handled in some central location.
Probably needs to be added everywhere, probably not in a central location as each file format could be different. We need to set it on old Inkscape SVG files too.
Also, regarding bug 1278645, setting the above line in the <image> fixes the EMF/WMF image output. Which tells us that the default value for preserveAspectRatio is doing something wrong for the one image in the test case. That test is from start to finish just a (10,10) bitmap, but for some reason it gets trimmed down to a (5,5) in SPImage::print in sp-image.cpp in the default case, but stays (10,10) for "none".
There is an "if" statement in SPImage::print which I believe handles non-Cairo output that special cases 'none' from the rest. This is where to look for the fix. I don't have an easy way to view wmf and emf files...
Putting that preserveAspectRatio in the <svg> at the top of the file does NOT resolve the EMF/WMF image output issue, it has to be in (each) <image>. Is that right - or should the <image> inherit its preserveAspectRatio from the <svg> within which it resides?
'preserveAspectRatio' is an attribute, not a property, which means that it is not handled by the normal CSS type style cascade. It must be set on each element that it applies to. There is a 'defer' value which we don't handle at all that says to look inside the referenced content for the value.
preserveAspectRatio applies to:
<svg> <symbol> <image> <feimage> <marker> <pattern> <view>are we going to have similar issues with any of these?
We shouldn't but it wouldn't hurt to check. <image> is a bit special in that the default value for 'preserveAspectRatio' is not what seems to be used by most other graphics file formats. The other elements are more SVG specific.
I do have some more changes I am working on but as they are probably more invasive than what I have done already I'll make them available in a separate branch first.
Tav