On Tue, Mar 08, 2005 at 11:13:20PM -0400, bulia byak wrote:
On Tue, 8 Mar 2005 23:42:12 +0100, Jean-François Lemaire <jflemaire@...621...> wrote:
- Draw a shape
- Apply a gradient to it, change it a bit for good measure
- Undo until you're back at stage 1
- Redo
- The gradient is now dead in the middle of the shape and when you try
to modify it it becomes white.
[...] By trying timed CVS updates I tracked it down to mental's commit on Tue Mar 1 23:43:25 2005 UTC which touched these files:
P src/xml/Makefile_insert cvs update: src/xml/node-listener.h is no longer in the repository P src/xml/node-observer.h P src/xml/repr.cpp P src/xml/simple-node.cpp P src/xml/simple-node.h
This was caused by a bug in ListContainer::pop_front, which wasn't correctly adjusting _tail.
I've fixed this, as well as a couple of other bugs I noticed. I also changed check_values to try to test back() as an indirect way of checking that _tail is correct: though note that this won't check _tail correctness if the list is empty. mental, you might consider somehow adding a test that _tail is correct whenever the list is empty. It seems to me that it's fairly easy to forget to adjust _tail correctly.
pjrm.